Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove deprecated mkdir, mkdirSync APIs #4615

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Apr 3, 2020

While updating the API documentation, I noticed that mkdir and mkdirSync were the only APIs with deprecated variants. This PR removes these deprecated variants to clean up the API in advance of the Deno 1.0 release. The variants removed have been deprecated since 0.29.0.

@cknight
Copy link
Contributor Author

cknight commented Apr 4, 2020

@ry - ready for review. Feel free to close without merge if you'd prefer to keep this deprecated API longer.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this @cknight

@ry ry merged commit 2becae8 into denoland:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants